drivers: bluetooth: silabs: Add hardware-dependent feature detection #97994
+218
−93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Bluetooth
area: Devicetree Bindings
area: Boards/SoCs
platform: Silabs
zephyrbot
requested review from
HaavardRei,
HoZHel,
Martinhoff-maker,
PavelVPV,
Thalley,
alwa-nordic,
asmellby,
cvinayak,
hermabe,
jerome-pouiller,
jhedberg and
sjanc
Contributor
Author
|
@jrintaha fyi |
soc/silabs/silabs_s2/Kconfig
Outdated
| def_bool $(dt_nodelabel_bool_prop,radio,ble-2mbps-supported) | ||
|
|
||
| config HAS_HW_EFR32_RADIO_BLE_CODED | ||
| def_bool $(dt_nodelabel_bool_prop,radio,ble-coded-phy-supported) |
Contributor
There was a problem hiding this comment.
Do we need these intermediate symbols (HAS_HW_EFR32_RADIO_*)?
Contributor
Author
There was a problem hiding this comment.
i think it is easier to define dependencies with these, like for example HAS_HW_EFR32_RADIO_CTE_RX
Contributor
There was a problem hiding this comment.
Not a blocker, but I have always had some doubts about the benefit of adding new global helper symbols. They are sometime used to hide some logic (now or in further PR) and may make the reader work more difficult.
cvinayak
reviewed
Oct 21, 2025
cvinayak
dismissed
their stale review
No strong change requests pending from me,
zephyrbot
requested review from
3rang,
cvinayak,
jhedberg,
kartben,
nashif,
pideu-sj and
rerickson1
ipankr
force-pushed
the
main
branch
3 times, most recently
from
23169a0 to
46a301c
Compare
Thalley
removed request for
HaavardRei,
HoZHel,
Martinhoff-maker,
Thalley,
bjarki-andreasen,
pideu-sj and
ppryga-nordic
Vendor specific configuration is moved to a separate file. Signed-off-by: Ivan Pankratov <[email protected]>
Create a shared base binding (ble-radio.yaml) for common Bluetooth LE radio hardware capabilities to avoid duplication between vendors and ensure consistent property naming across the ecosystem. Properties are prefixed with 'ble-' and ordered chronologically by Bluetooth Core Specification version (5.0, 5.1, 6.0). Each property indicates a hardware capability, not current enablement state. Signed-off-by: Ivan Pankratov <[email protected]>
…-pins Rename generic FEM binding to use 'radio-' prefix for consistency with other radio bindings (radio.yaml, ble-radio.yaml). Updated 3 board files, Nordic BLE controller HAL, documentation, and test overlays. Added missing settle-time properties to pan1783a board. Signed-off-by: Ivan Pankratov <[email protected]>
Rename GPIO coex binding to use 'radio-' prefix for consistency with other radio bindings (radio.yaml, radio-fem-two-ctrl-pins.yaml). Updated beacon sample overlay and coex documentation. Signed-off-by: Ivan Pankratov <[email protected]>
Add migration guide and release notes entries for the radio-related devicetree binding renames: - generic-fem-two-ctrl-pins -> radio-fem-two-ctrl-pins - gpio-radio-coex -> radio-gpio-coex - tx-high-power-supported -> radio-tx-high-power-supported Also document the new radio.yaml base binding for generic radio hardware capabilities. Signed-off-by: Ivan Pankratov <[email protected]>
|
jerome-pouiller
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR creates a shared base binding for common Bluetooth LE radio hardware capabilities to avoid duplication between vendors and ensure consistent property naming across the Zephyr ecosystem.
Changes
New Base Binding
Updated Vendor Bindings
Silabs:
Nordic:
Silicon Labs Device Trees
Updated all Series 2 SoCs with hardware-supported features:
Nordic Device Trees
Updated with consistent property naming:
Kconfig Integration
Silabs - Added hardware capability flags (auto-detected from DT):
Silabs HCI driver automatically selects controller features based on hardware capabilities.
Nordic - Updated Kconfig to reference renamed properties:
Testing
Verified on all affected hardware (11 board configurations):
Design Philosophy
This approach harmonizes devicetree bindings across vendors while respecting each vendor's driver architecture.